Skip to content

Conversation

@jakehwll
Copy link
Contributor

@jakehwll jakehwll commented Dec 8, 2025

This pull-request is going through and removing various props that still use css and replacing them with their className /Tailwind variants.

WIP.

}}
>
<header className="p-6">
<div className="text-xl font-semibold m-0 leading-[inherit]">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love that this is leading-[inherit] but it was causing the text to shift mildly. Inline with hoping to make this change as unobtrusive as possible I kept this at the baseline.

marginTop: 8,
}}
>
<div className="text-sm text-content-secondary mt-2 leading-[inherit]">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

I don't love that this is leading-[inherit] but it was causing the text to shift mildly. Inline with hoping to make this change as unobtrusive as possible I kept this at the baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants