-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: remove various MUI/emotion css props
#21154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| }} | ||
| > | ||
| <header className="p-6"> | ||
| <div className="text-xl font-semibold m-0 leading-[inherit]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love that this is leading-[inherit] but it was causing the text to shift mildly. Inline with hoping to make this change as unobtrusive as possible I kept this at the baseline.
| marginTop: 8, | ||
| }} | ||
| > | ||
| <div className="text-sm text-content-secondary mt-2 leading-[inherit]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
I don't love that this is
leading-[inherit]but it was causing the text to shift mildly. Inline with hoping to make this change as unobtrusive as possible I kept this at the baseline.
This pull-request is going through and removing various props that still use
cssand replacing them with theirclassName/Tailwind variants.WIP.