-
Notifications
You must be signed in to change notification settings - Fork 957
fix: set prebuilds lifecycle parameters on creation and claim #19252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ec09fd8
to
dd57747
Compare
dd57747
to
6415069
Compare
@@ -521,6 +524,9 @@ WHERE | |||
id = $1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: make it impossible by adding AND owner_id != ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn’t sure at first whether to enforce it at the database level or just in the application layer, but I agree it makes more sense to make it impossible by adding a DB-level constraint.
Addressed in 4c847c9 and I’ve updated the other relevant queries as well to align with it.
As suggested, the scope of this PR was reduced by splitting the original implementation into smaller, more focused PRs. |
…prebuilt workspaces
…uilds-lifecycle-params
Description
This PR ensures that prebuilt workspaces are properly excluded from the lifecycle executor and treated as a separate class of workspaces, fully managed by the prebuild reconciliation loop.
It introduces two lifecycle guarantees:
Changes
Relates
Related issue: #18898
To reduce the scope of this PR and make the review process more manageable, the original implementation has been split into the following focused PRs:
These PRs should be reviewed in conjunction with this one to understand the complete set of lifecycle separation changes for prebuilt workspaces.