fix: exclude prebuilt workspaces from template-level lifecycle updates #19265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

ssncferreira wants to merge 1 commit into main from ssncferreira/fix-template-update-ignore-prebuilds

Contributor

ssncferreira commented Aug 8, 2025 •

edited

Loading

Description

This PR ensures that lifecycle-related changes made via the /templates/{template} endpoint do not affect prebuilt workspaces. Since prebuilds are managed by the reconciliation loop and do not participate in the regular lifecycle executor flow, they must be excluded from any updates triggered by template configuration changes.

This includes changes to TTL, dormancy thresholds, or dormant-deletion scheduling.

Changes

Updated SQL query UpdateWorkspacesTTLByTemplateID to exclude prebuilt workspaces
Updated SQL query UpdateWorkspacesDormantDeletingAtByTemplateID to exclude prebuilt workspaces
Updated application-layer logic to skip any updates to lifecycle parameters if a workspace is a prebuild
Preserved all existing update behavior for regular user workspaces

This change guarantees that only lifecycle-managed workspaces are affected when template-level configurations are modified, preserving strict boundaries between prebuild and user workspace lifecycles.

Related with:


          fix: exclude prebuilt workspaces from template-level lifecycle updates

b08282a

github-actions bot assigned ssncferreira

ssncferreira mentioned this pull request

fix: set prebuilds lifecycle parameters on creation and claim #19252

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet