DEV: Reduce unnecessary UI updates when posts change #33918
Merged
+51
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced promise chaining with async/await syntax to improve clarity and handle asynchronous logic. Added JSDoc comments to document method parameters and behavior. Updated logic to conditionally preserve cooked HTML and ensure the topic reference is correctly updated.
Updated property assignment logic in `store` to only update changed values, preventing unnecessary rerenders in Glimmer.
Removed unnecessary resolved promise and streamlined the return behavior for cases where `postId` is not provided.
Introduced `untrack` and `deepEqual` to optimize property comparisons. Updated logic to batch property updates, ensuring rerenders are only triggered when necessary.
Prevents max call stack errors in the comparison logic by replacing `deepEqual` with a strict equality check (`===`).
davidtaylorhq
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the post update logic in the post stream and store services to minimize unnecessary UI rerenders:
StoreService, properties are selectively updated: only changed values are applied, preventing redundant updates and improving render efficiency.untrackto avoid creating unwanted Glimmer tracking contexts during property comparisons, reducing computation errors.This PR is improves #33864 which was reverted by #33917 due to the possibility of tracking errors in edge cases.