Revert "DEV: Reduce unnecessary UI updates when posts change (#33864)" #33917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

megothss merged 1 commit into main from dev/revert-33864

Jul 29, 2025

+15 −40

Contributor

megothss commented Jul 29, 2025

This reverts commit 38f7517.


          Revert "DEV: Reduce unnecessary UI updates when posts change (#33864)"

5254bf3

This reverts commit 38f7517.

lis2 approved these changes

View reviewed changes

megothss merged commit 7062666 into main

17 checks passed

megothss deleted the dev/revert-33864 branch

July 29, 2025 01:18

megothss mentioned this pull request

DEV: Reduce unnecessary UI updates when posts change #33918

Merged

megothss added a commit that referenced this pull request


          DEV: Reduce unnecessary UI updates when posts change (#33918)

216df43

This commit refactors the post update logic in the post stream and store
services to minimize unnecessary UI rerenders:

- In `StoreService`, properties are selectively updated: only changed
values are applied, preventing redundant updates and improving render
efficiency.
- Uses `untrack` to avoid creating unwanted Glimmer tracking contexts
during property comparisons, reducing computation errors.
- All property updates are batched to trigger a single rerender.

This PR is improves #33864
which was reverted by #33917
due to the possibility of tracking errors in edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet