DEV: Reduce unnecessary UI updates when posts change #33864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

megothss wants to merge 3 commits into main from dev/prevent-rerenderings

+40 −15

Contributor

megothss commented Jul 25, 2025 •

edited

Loading

This PR refines how posts are updated in the post stream and store service to minimize unnecessary UI re-renders.

In the store service, only changed properties are set on existing records, preventing redundant updates and improving Glimmer performance.

megothss added 3 commits

July 25, 2025 14:01


          DEV: Refactor triggerChangedPost to use async/await

09655f4

Replaced promise chaining with async/await syntax to improve clarity and handle asynchronous logic. Added JSDoc comments to document method parameters and behavior.

Updated logic to conditionally preserve cooked HTML and ensure the topic reference is correctly updated.


          PERF: Avoid unnecessary rerenders in store

87055c1

Updated property assignment logic in `store` to only update changed values, preventing unnecessary rerenders in Glimmer.


          DEV: Simplify triggerChangedPost return logic

974fe4b

Removed unnecessary resolved promise and streamlined the return behavior for cases where `postId` is not provided.

megothss changed the title ~~DEV: Optimize re-renders when updating posts~~ DEV: Reduce unnecessary UI updates when posts change

CvX approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet