test(scaletest/workspacetraffic): fix test flake due to io.EOF on close #21231
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many cases where the code being called would return io.EOF, so skipping it seems like a reasonable easy-fix to this flake. Fixes coder/internal#119
53f106c to
dca88ad
Compare
DanielleMaywood
approved these changes
Dec 12, 2025
Contributor
DanielleMaywood
left a comment
There was a problem hiding this comment.
Approving although curious as to why we're receiving EOF
Member
Author
|
@DanielleMaywood Typically EOF is not an error we care about at the end of the test, it just tells us that the connection is already closed. It could be that one side went away earlier, or that our connection teardown has a slight raciness to it. That said, we could make this fix more extensive as there's an actual bug in Without a solid repro, though, this is speculative. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many cases where the code being called would return io.EOF, so
skipping it seems like a reasonable easy-fix to this flake.
Fixes coder/internal#119