Skip to content

Commit dca88ad

Browse files
committed
test(scaletest/workspacetraffic): fix test flake due to io.EOF on close
There are many cases where the code being called would return io.EOF, so skipping it seems like a reasonable easy-fix to this flake. Fixes coder/internal#119
1 parent 2e4aa72 commit dca88ad

File tree

1 file changed

+5
-1
lines changed
  • scaletest/workspacetraffic

1 file changed

+5
-1
lines changed

scaletest/workspacetraffic/run.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package workspacetraffic
33
import (
44
"bytes"
55
"context"
6+
"errors"
67
"fmt"
78
"io"
89
"math/rand"
@@ -131,8 +132,11 @@ func (r *Runner) Run(ctx context.Context, _ string, logs io.Writer) (err error)
131132
closeConn := func() error {
132133
closeOnce.Do(func() {
133134
closeErr = conn.Close()
134-
if closeErr != nil {
135+
if errors.Is(closeErr, io.EOF) {
136+
closeErr = nil
137+
} else if closeErr != nil {
135138
logger.Error(ctx, "close agent connection", slog.Error(closeErr))
139+
closeErr = xerrors.Errorf("close agent connection: %w", closeErr)
136140
}
137141
})
138142
return closeErr

0 commit comments

Comments
 (0)