fix(site): hide "Show parent apps" when no running or starting devcontainers #19200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Aug 6, 2025
|
I've added a storybook but I've noticed it doesn't actually show the devcontainer, and after running storybook in my workspace the existing I've tried fixing this myself, and with the aid of Claude Opus 4.1, but I've not had any luck. I believe the main issue is our component is handling both data fetching and rendering, whereas with other parts of the codebase we follow the pattern: @aslilac Do you think we should follow the same approach here? |
|
that's one approach, but you can also just mock the query response by setting the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19199
We now hide the "Show parent apps" button when there are no running or starting devcontainers.