Skip to content

chore: remove vestiges of Jest internally #11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: remove vestiges of Jest internally #11385

wants to merge 3 commits into from
+1 −30

Conversation

cseas
Copy link
Contributor

@cseas cseas commented Jul 8, 2025

PR Checklist

Overview

Removed mentions of Jest mentioned in #11078 (review) along with some other places I could find.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @cseas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 8, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 36270ba
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/688171dbbfadcf0008f6c865
😎 Deploy Preview https://deploy-preview-11385--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 36270ba

Command Status Duration Result
nx run integration-tests:test ❌ Failed 50s View ↗
nx run ast-spec:test -- --coverage ❌ Failed 12s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 18s View ↗
nx run-many -t lint ✅ Succeeded 3m 16s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 19s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 12s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 4s View ↗
Additional runs (13) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-23 23:43:44 UTC

@kirkwaiblinger
Copy link
Member

kirkwaiblinger commented Jul 9, 2025 •
edited
Loading

FYI @aryaemami59 / @43081j

@43081j
Copy link
Contributor

43081j commented Jul 10, 2025

looks good to me 👍

aryaemami59
aryaemami59 reviewed Jul 14, 2025
View reviewed changes
Copy link
Contributor

@aryaemami59 aryaemami59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@kirkwaiblinger
Copy link
Member

Looks like there are still a handful of mentions to be cleaned up?

typescript-eslint/docs/contributing/Pull_Requests.mdx

Lines 52 to 53 in 3bb4f1d

[Jest snapshots](https://jestjs.io/docs/snapshot-testing) are generated for use in some tests, e.g. for [rule schemas](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/tests/schema-snapshots) and [code examples in rule docs](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/tests/docs-eslint-output-snapshots). You may need to re-generate these snapshots after adjusting a rule and/or its documentation, by running the relevant test suite(s) with the `-u` flag:

typescript-eslint/docs/maintenance/Pull_Requests.mdx

Line 83 in 63ab002

- All lines are covered per the Codecov / `yarn jest path/to/impacted/file --coverage` report.

kirkwaiblinger
kirkwaiblinger requested changes Jul 14, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comment)

@kirkwaiblinger kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Jul 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (6d8fae9) to head (c253892).
Report is 1 commits behind head on main.

❗ Current head c253892 differs from pull request most recent head 36270ba

Please upload reports for the commit 36270ba to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11385      +/-   ##
==========================================
- Coverage   90.86%   90.85%   -0.02%     
==========================================
  Files         503      501       -2     
  Lines       51046    50987      -59     
  Branches     8418     8410       -8     
==========================================
- Hits        46384    46324      -60     
  Misses       4648     4648              
- Partials       14       15       +1
Flag Coverage Δ
unittest 90.85% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cseas
Copy link
Contributor Author

cseas commented Jul 23, 2025 •
edited
Loading

Looks like there are still a handful of mentions to be cleaned up?

@kirkwaiblinger Done ✅
Let me know if there are any specific parts that should be replaced with Vitest equivalents.

@cseas cseas requested a review from kirkwaiblinger July 24, 2025 00:01
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryaemami59 aryaemami59 aryaemami59 left review comments

@kirkwaiblinger kirkwaiblinger Awaiting requested review from kirkwaiblinger

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Remove vestiges of Jest internally
4 participants
@cseas @kirkwaiblinger @43081j @aryaemami59