Skip to content

Conversation

@matren33
Copy link

@matren33 matren33 commented Dec 3, 2025

Issue #1212 compliance

This PR adds a versions.txt file to Windows releases that lists all installed packages and their versions

Changes

  • Added _generate_versions_file() function to generate versions.txt using pip list --format=json
  • Modified _build_windows_single() to call the new function after smoke tests
  • The file is automatically included in both the installer and standalone zip

mathis renaud and others added 2 commits November 12, 2025 16:36
Replaces the deprecated `pkg_resources` library and the hardcoded dependency list in `_generate_versions_file` with dynamic approach using the `pip list --format=json` system command

This change:
* Resolves deprecation warnings related to `pkg_resources`
* Dynamically captures the full list of installed Python dependencies and their versions for improved debugging and release metadata
* Formats the output as standard `Package==Version`
* Removes verbose headers for a cleaner dependency list
@The-Compiler
Copy link
Member

Did you actually test this, or is "The file is automatically included in both the installer and standalone zip" just whatever the AI tool you use is claiming?

@matren33
Copy link
Author

matren33 commented Dec 4, 2025

Ok... We already tested this locally with the #8780 fix and it works normally.
It generates both in dist/qutebrowser and in standalone zip.

@l4-s0
Copy link

l4-s0 commented Dec 4, 2025

Did you actually test this, or is "The file is automatically included in both the installer and standalone zip" just whatever the AI tool you use is claiming?

Just tested this locally too, it does works properly : versions.txt is indeed generated both in dist\qutebrowser\ and in the standalone zip.

This testing was possible for us thanks to #8780, (especially for the NSIS path) otherwise the build would have failed for both of us before reaching the versions.txt generation step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants