Improve Windows build detection for Python and NSIS #8780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

l4-s0 wants to merge 1 commit into qutebrowser:main from l4-s0:test-build

+63 −6

l4-s0 commented Nov 17, 2025 •

edited

Loading

Context

Builds using tox -e build-release would fail because Python and NSIS were not detected in certain configurations, for example if they were not on the PATH.

Python: If installed only for the current user (not system-wide) or via Microsoft Store, the build script could not locate the executable because it didn’t check the correct PATH locations or the HKEY_CURRENT_USER registry keys.
NSIS: If installed in non-standard locations, or not on PATH, makensis.exe could not be found.

Fix

Added additional fallback paths for Python detection.
Added similar fallback logic for NSIS.

With these changes, the build script now correctly locates Python and NSIS in all common user environments, including Microsoft Store installations and user-only installs. This allows tox -e build-release to run successfully without requiring system-wide Python or manually modifying PATH.

Member

The-Compiler commented Nov 17, 2025

I'm not really interested in all the additional complexity if it doesn't solve a real-world issue. Why do you need to build your own custom builds in the first place?

Author

l4-s0 commented Nov 17, 2025 •

edited

Loading

Thanks for you response !

For my first contribution I was trying to work on the issue : "Add a versions.txt to windows releases #1212". In order to do so, I needed to run tox -e build-release on Windows.

On my setup, the build couldn’t detect Python or NSIS at all. This PR only adds small fallback checks so contributors on Windows setups can run the build without manually fixing PATH or registry entries.

I didn't really mean to create my own custom build in the first place. By the way, the original versions.txt issue (#1212) is being handled by my teammate, who will open a PR soon.

I totally understand if this extra robustness isn’t needed — though it could maybe still help future contributors on Windows. If you prefer to keep things simpler, I can close the PR without any issue.

PS : My teammate is encountering the same issue with the NSIS path, merging this PR would allow him to post his PR for (#1212)

l4-s0 marked this pull request as ready for review

November 17, 2025 15:18

l4-s0 changed the title ~~Add fallbacks for Python and NSIS detection in Windows build_release~~ Fix line breaks

l4-s0 changed the title ~~Fix line breaks~~ Improve Windows build detection for Python and NSIS


          Add Python and NSIS path fallbacks for Windows build (build_release)

44aa633

l4-s0 force-pushed the test-build branch from 29094c8 to 44aa633 Compare

November 17, 2025 16:46

The-Compiler moved this to Inbox in Pull request backlog

The-Compiler added this to Pull request backlog

The-Compiler moved this from Inbox to Focus in Pull request backlog

matren33 mentioned this pull request

Add versions.txt to Windows releases #8808

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet