Skip to content

gh-137134: Update SQLite to 3.50.3 for binary releases #137135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Jul 27, 2025


Draft mode as this PR is probably only a start at the moment. I expect I've missed some bits and I think we need the macOS, Windows, and Android release builders to weigh in and confirm stuff works.

Two separate news entries per platform is odd, Android didn't get a news mention - we might want to rethink our categories for this kind of update? I was mirroring what I saw done for the 3.49.1 update.

@gpshead
Copy link
Member Author

gpshead commented Jul 27, 2025

I believe I pushed the SQLite 3.50.3 sources to https://github.com/python/cpython-source-deps/releases/tag/sqlite-3.50.3.0 properly.

@mhsmith
Copy link
Member

mhsmith commented Jul 28, 2025

I've added builds of this version to https://github.com/beeware/cpython-android-source-deps.

@mhsmith
Copy link
Member

mhsmith commented Jul 28, 2025

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit c69125d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137135%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@zware
Copy link
Member

zware commented Jul 28, 2025

I believe I pushed the SQLite 3.50.3 sources to https://github.com/python/cpython-source-deps/releases/tag/sqlite-3.50.3.0 properly.

Somehow the sqlite branch head and the sqlite-3.50.3.0 tag refer to different commits that differ only in CommitDate. Other than that, either commit does the update correctly.

Oh, except that both branch from the sqlite-3.45.3.0 tag, not from sqlite-3.49.1.0 :(

@gpshead
Copy link
Member Author

gpshead commented Jul 29, 2025

except that both branch from the sqlite-3.45.3.0 tag, not from sqlite-3.49.1.0 :(

I don't think this matters? at least not any more so than it not mattering the past few updates? All the sqlite- tags since that 3.45.3.0 one are in a similar state. I think this is due to people using a fork to push to initially? the commits "don't appear in this repository" which I think is GH for they're identified as being in a fork's repo? (GH repos are a unified hash namespace across all forks) A little confusing to me how github manages such a weird state of a tag in a repo who's commit claims not to be.

in my own fork i probably re-pushed my branch after fixing the commit signing after getting that setup in order to follow the instructions that wanted a signed tag. (my tag was signed regardless)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants