Skip to content

Prepare v1.2.0 #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2023
Merged

Prepare v1.2.0 #2538

merged 3 commits into from
Jan 28, 2023

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Jan 25, 2023

@pierreprinetti pierreprinetti added this to the v1.2.0 milestone Jan 25, 2023
@coveralls
Copy link

coveralls commented Jan 25, 2023

Coverage Status

Coverage: 80.092% (+0.007%) from 80.086% when pulling 2535503 on shiftstack:prepare_v1.2.0 into 3763b92 on gophercloud:master.

EmilienM
EmilienM previously approved these changes Jan 25, 2023
@EmilienM
Copy link
Contributor

LGTM

/cc @mandre

@mandre
Copy link
Contributor

mandre commented Jan 27, 2023

Great, could you just make sure you're adding a release note for 3bba9b2 as well, then we can follow the release instruction you wrote in #2539 to cut v1.2.0.

The changelog for v1.2.0 is the output of:

```
gh pr list \
        --state merged \
        --search 'milestone:v1.2.0' \
        --json number,title \
        --template \
        '{{range .}}* {{ printf "[GH-%v](https://github.com/gophercloud/gophercloud/pull/%v)" .number .number }} {{ .title }}
{{end}}'
```
EmilienM
EmilienM previously approved these changes Jan 27, 2023
Copy link
Contributor

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@mandre for merge

@pierreprinetti
Copy link
Member Author

@mandre
I have (slightly modified and) merged #2519, so that this "Prepare v1.2.0" is virtually identical to the next one.

The changelog for v1.2.0 is the output of:

```
gh pr list \
        --state merged \
        --search 'milestone:v1.2.0' \
        --json number,title \
        --template \
        '{{range .}}* {{ printf "[GH-%v](https://github.com/gophercloud/gophercloud/pull/%v)" .number .number }} {{ .title }}
{{end}}'
```
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge whenever you want @pierreprinetti . Just double check my last commit to see if it's fine with you.

@pierreprinetti pierreprinetti merged commit e0878b0 into gophercloud:master Jan 28, 2023
@pierreprinetti pierreprinetti deleted the prepare_v1.2.0 branch January 28, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants