-
Notifications
You must be signed in to change notification settings - Fork 560
Modify user-agent header to ensure current gophercloud version is provided #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
Unless you have reasons to be more specific, I would propose to only mention the major version number: |
@pierreprinetti That would for sure be suitable. If you prefer this approach I will adapt accordingly. My logic for wanting the exact version comes from an operator perspective.
Other than that it's simply for statistics (and personal curiosity about how often people update). |
Latest test failures appear to be related to a hiccup on CI apt mirrors. Not sure how to re-trigger them
|
@pierreprinetti any blockers with this PR or are we simply awaiting next release for merge ? |
@mandre |
Hi @pierreprinetti, I see this PR missed the v1.1.1 release and also that v1.2.0 is coming up. Would it be possible to include this in the 1.2.0 release or does it need it's own |
@UmBsublime I have modified your PR so that:
Thank you! |
Fixes #2511
In addition to this change a new github action will be required to ensure there is no version drift.
This version should stay in-line with the current release of gophercloud