Skip to content

Impeller gemini md #172724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gaaclarke
Copy link
Member

Added gemini.md file for impeller and tweaked the root gemini.md.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jul 24, 2025
@gaaclarke gaaclarke requested review from flar and matanlurey July 24, 2025 21:25
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

../bin/et build -c host_debug_unopt_arm64 \
//flutter/impeller/golden_tests:impeller_golden_tests
mkdir -p ~/Desktop/impeller_unit_tests
pushd $PWD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can combine pushd/cd into just one pushd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW it seems to ignore this suggestion verbatim. It looks like it has it's own shell that it is fine changing the directory in that gets reset the next time the execute code.

Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is worth mentioning that the OpenGL tests take the most time and I usually run this with --gtest_filter="-*/OpenGLES" to dramatically reduce the runtime. It still tests on Metal and Vulkan, but those back ends don't have nearly the "per-test-setup" overhead of OpenGL.

@gaaclarke gaaclarke force-pushed the impeller-gemini-md branch from e44cb48 to 4ee5fa4 Compare July 24, 2025 22:31
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2025
Copy link
Contributor

auto-submit bot commented Jul 24, 2025

autosubmit label was removed for flutter/flutter/172724, because - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants