-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Impeller gemini md #172724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Impeller gemini md #172724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
../bin/et build -c host_debug_unopt_arm64 \ | ||
//flutter/impeller/golden_tests:impeller_golden_tests | ||
mkdir -p ~/Desktop/impeller_unit_tests | ||
pushd $PWD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can combine pushd/cd into just one pushd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW it seems to ignore this suggestion verbatim. It looks like it has it's own shell that it is fine changing the directory in that gets reset the next time the execute code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it is worth mentioning that the OpenGL tests take the most time and I usually run this with --gtest_filter="-*/OpenGLES"
to dramatically reduce the runtime. It still tests on Metal and Vulkan, but those back ends don't have nearly the "per-test-setup" overhead of OpenGL.
e44cb48
to
4ee5fa4
Compare
autosubmit label was removed for flutter/flutter/172724, because - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Added gemini.md file for impeller and tweaked the root gemini.md.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.