Re-enabled flaky UI test TextInEditorShouldScroll #29167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| #if MACCATALYST | ||
| App.ScrollDown("editor"); // To make sure the editor is scrolled down | ||
| var yPos = yPosLabel.GetText(); | ||
| Assert.That(yPos,Is.GreaterThan("0")); // The Y position should be greater than 0 after scrolling down |
There was a problem hiding this comment.
Just a note — since this is a UITest, ideally we should verify that scrolling is visually reflected in the UI. Relying on ContentOffset.Y > 0 introduces a logical check, but it doesn’t fully guarantee a visible change occurred on screen.
There was a problem hiding this comment.
@bhavanesh2001 , The test is to check whether the editor is scrollable or not. The previous UI test was flaky because the content was scrolled a pixel off from its original position. So instead of relying on a visual confirmation, I went with an alternative approach. The Y position label text will be updated only if the editor is scrolled. Otherwise it stays as 0.
This is added only to MAC to resolve flaky issue on CI.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
previously approved these changes
May 5, 2025
PureWeen
approved these changes
May 5, 2025
PureWeen
pushed a commit
that referenced
this pull request
May 5, 2025
* Fixed flaky editor test * Added scroll down again to double check * Optimized code changes and added new test snapshots * Added missing WinUI snap
PureWeen
added a commit
that referenced
this pull request
May 8, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process ## .NET MAUI Release Notes - inflight/candidate This document contains release notes for changes from main branch to inflight/candidate branch. ### MAUI Product Fixes * [iOS] Fix: FlyoutPage memory leak by @bhavanesh001 in #28769 * [Windows] Fix for CarouselView IsSwipeEnabled=False Prevents Visual Navigation by @SubhikshaSF4852 in #29286 * [Windows] Fix for Argument Exception raised when the GetStringSize method of ICanvas called with default font by @SyedAbdulAzeemSF4852 in #29048 * Removed frame styles by @Vignesh-SF3580 in #29222 * [Android] Fixed the CollectionView Header and Footer Do Not Align with Horizontal ItemsLayout When EmptyView is Displayed by @Ahamed-Ali in #28779 * Add global xmlns in template by @StephaneDelcroix in #29203 * Fixed - On iOS GestureRecognizers don't work on Span in a Label, which doesn't get IsVisible (=true) update from its parent by @KarthikRajaKalaimani in #29024 * Fixed Footer not displayed at the Bottom When EmptyView in CV2 by @Dhivya-SF4094 in #28681 * Fixed typo in Connectivity.shared.cs by @corvinsz in #29213 ### Testing * Re-enabled flaky UI test TextInEditorShouldScroll by @NirmalKumarYuvaraj in #29167 * [Testing] Re-Enabled UI Test - Issue10222Test by @TamilarasanSF4853 in #29226 * [Testing] Feature Matrix UITest Cases for CollectionView Selection Feature by @LogishaSelvarajSF4525 in #29165 ### Dependency Updates *No dependency updates in this release* ### Docs *No documentation changes in this release* ### Housekeeping *No housekeeping changes in this release* ## New Contributors * @corvinsz made their first contribution in #29213 **Full Changelog**: main...inflight/candidate
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
* Fixed flaky editor test * Added scroll down again to double check * Optimized code changes and added new test snapshots * Added missing WinUI snap
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
TextInEditorShouldScrollto verify scrolling behavior using ayPositionLabelinstead of relying on screenshot validation. This ensures the test is more deterministic and avoids flakiness in CI, particularly for macOS.Issues Fixed
Fixes #29025