[Testing] Re-Enabled UI Test - Issue10222Test #29226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables and improves the UI test for Issue 10222 to address intermittent failures on Android by refining the test flow and user interaction handling. Key changes include:
- Re-enabling the test on Android by removing platform-specific exclusion directives.
- Removing hardcoded timeouts and adding clearer tap operations in the test case.
- Adding a tap gesture recognizer in the host app to trigger scrolling and intended navigation behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue10222.cs | Removed platform-specific directives and modified wait and tap operations. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue10222.cs | Introduced an inline list for items and added a tap gesture recognizer with an async handler. |
| } | ||
|
|
||
| // Scrolls to last item then pops the page | ||
| async void LabelTapped() |
There was a problem hiding this comment.
The comment indicates that tapping the label should scroll to the last item and then pop the page, but the implementation only scrolls to the last item without executing any pop operation. Please add the necessary navigation pop action to match the intended behavior.
Copilot uses AI. Check for mistakes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously approved these changes
Apr 30, 2025
PureWeen
approved these changes
May 1, 2025
anandhan-rajagopal
pushed a commit
to anandhan-rajagopal/maui
that referenced
this pull request
May 5, 2025
* enabled the test case for android * added comment
PureWeen
pushed a commit
that referenced
this pull request
May 5, 2025
* enabled the test case for android * added comment
PureWeen
pushed a commit
that referenced
this pull request
May 5, 2025
* enabled the test case for android * added comment
PureWeen
added a commit
that referenced
this pull request
May 8, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process ## .NET MAUI Release Notes - inflight/candidate This document contains release notes for changes from main branch to inflight/candidate branch. ### MAUI Product Fixes * [iOS] Fix: FlyoutPage memory leak by @bhavanesh001 in #28769 * [Windows] Fix for CarouselView IsSwipeEnabled=False Prevents Visual Navigation by @SubhikshaSF4852 in #29286 * [Windows] Fix for Argument Exception raised when the GetStringSize method of ICanvas called with default font by @SyedAbdulAzeemSF4852 in #29048 * Removed frame styles by @Vignesh-SF3580 in #29222 * [Android] Fixed the CollectionView Header and Footer Do Not Align with Horizontal ItemsLayout When EmptyView is Displayed by @Ahamed-Ali in #28779 * Add global xmlns in template by @StephaneDelcroix in #29203 * Fixed - On iOS GestureRecognizers don't work on Span in a Label, which doesn't get IsVisible (=true) update from its parent by @KarthikRajaKalaimani in #29024 * Fixed Footer not displayed at the Bottom When EmptyView in CV2 by @Dhivya-SF4094 in #28681 * Fixed typo in Connectivity.shared.cs by @corvinsz in #29213 ### Testing * Re-enabled flaky UI test TextInEditorShouldScroll by @NirmalKumarYuvaraj in #29167 * [Testing] Re-Enabled UI Test - Issue10222Test by @TamilarasanSF4853 in #29226 * [Testing] Feature Matrix UITest Cases for CollectionView Selection Feature by @LogishaSelvarajSF4525 in #29165 ### Dependency Updates *No dependency updates in this release* ### Docs *No documentation changes in this release* ### Housekeeping *No housekeeping changes in this release* ## New Contributors * @corvinsz made their first contribution in #29213 **Full Changelog**: main...inflight/candidate
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
* enabled the test case for android * added comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request addresses improvements to a test case for Issue 10222 by refining the test logic, enhancing user interaction handling, and removing a platform-specific exclusion directive. The changes aim to make the test more robust and platform-independent.
Issue
Previously, the test was experiencing intermittent failures (flakiness) on Android due to asynchronous execution. The test was attempting to load items, scroll, and navigate back to the previous page while simultaneously validating item presence and checking page elements, leading to race conditions.
Solution
Redesigned the test flow to follow a more sequential and predictable pattern with load the items initially and then using tap operation to execute scroll and navigate back execution.
This sequential approach ensures each operation completes before the next begins, eliminating race conditions. Test cases have been updated accordingly to match this new flow pattern.
Fixes #28640
Note : This issue includes two test case problems. One test case has already been fixed by an Open contributor. PR - #28668