-
Notifications
You must be signed in to change notification settings - Fork 658
Clarify working directory assignment for project launch configurations #10681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also move the project launch configuration description into its own section of the spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR clarifies the working directory behavior for project launch configurations in the IDE execution specification. The main change involves reorganizing the documentation by moving the project launch configuration details into a dedicated section and adding explicit guidance about working directory assignment.
- Reorganized project launch configuration documentation into its own section for better structure
- Added clarification about working directory behavior for project execution
- Enhanced inline comments to better describe the "project" launch configuration type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| `project_path` | Path to the project file for the program that is being launched. | Required | | ||
| `mode` | Specifies the launch mode. Currently supported modes are `Debug` (run the project under the debugger) and `NoDebug` (run the project without debugging). | Optional, defaults to `Debug`. | | ||
| `launch_profile` | The name of the launch profile to be used for project execution. See below for more details on how the launch profile should be processed. | Optional | | ||
| `disable_launch_profile` | If set to `true`, the project will be launched without a launch profile and the value of "launch_profile" parameter is disregarded. | Optional | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for .NET projects, Is disable_launch_profile
always be false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, see how ExcludeLaunchProfileAnnotation
can be used to disable the launch profile, for example https://github.com/dotnet/aspire/blob/main/src/Aspire.Hosting/Dcp/DcpExecutor.cs#L957 and https://github.com/dotnet/aspire/blob/main/tests/Aspire.Hosting.Tests/ProjectResourceTests.cs#L289
@karolz-ms can you fix the markdown linting bugs. |
@davidfowl I did.. 1feefb1 Are there other bugs that I missed? |
Also move the project launch configuration description into its own section of the spec (this is why this change looks so big at first glance--but only the last paragraphs is new).
(spec only change, so omitting the full checklist)