Clarify working directory assignment for project launch configurations #10681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move the project launch configuration description into its own section of the spec
There was a problem hiding this comment.
Pull Request Overview
This PR clarifies the working directory behavior for project launch configurations in the IDE execution specification. The main change involves reorganizing the documentation by moving the project launch configuration details into a dedicated section and adding explicit guidance about working directory assignment.
- Reorganized project launch configuration documentation into its own section for better structure
- Added clarification about working directory behavior for project execution
- Enhanced inline comments to better describe the "project" launch configuration type
|
|
||
| b. If the `launch_profile` property is set, the IDE should check whether the service project has a launch profile with the name equal to the value of `launch_profile` property. If such profile is found, it should serve as the base profile. If not, there is no base profile. | ||
|
|
||
| b. If `launch_profile` property is absent, the IDE should check whether the service project has a launch profile with the same name as the profile used to launch Aspire application host project. If such profile is found, it should serve as the base profile. Otherwise there is no base profile. |
There was a problem hiding this comment.
There are two consecutive list items labeled 'b.' in the base profile determination rules. The second item should be labeled 'c.' for proper sequential ordering.
Suggested change
| b. If `launch_profile` property is absent, the IDE should check whether the service project has a launch profile with the same name as the profile used to launch Aspire application host project. If such profile is found, it should serve as the base profile. Otherwise there is no base profile. | |
| c. If `launch_profile` property is absent, the IDE should check whether the service project has a launch profile with the same name as the profile used to launch Aspire application host project. If such profile is found, it should serve as the base profile. Otherwise there is no base profile. |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move the project launch configuration description into its own section of the spec (this is why this change looks so big at first glance--but only the last paragraphs is new).
(spec only change, so omitting the full checklist)