Skip to content

Update AKV to depend on any MDS 6.x package #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

paulmedynski
Copy link
Contributor

Updated the AKV .nuspec file to declare it depends on any MDS 6.x package. This will make it compatible with the latest MDS 6.1.0 release, and any future MDS 6.x releases.

- Updated AKV to depend on all MDS 6.x versions.
@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 17:33
@paulmedynski paulmedynski requested a review from a team as a code owner July 25, 2025 17:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider NuGet package specification to expand its dependency version range for Microsoft.Data.SqlClient from [6.0.1,6.1.0) to [6.0.1,7.0.0), making it compatible with all 6.x releases including the latest 6.1.0 version.

  • Broadens Microsoft.Data.SqlClient dependency version range to include all 6.x releases
  • Maintains backwards compatibility while enabling forward compatibility within the major version
  • Applies the change consistently across all target frameworks (net462, net8.0, net9.0)

benrr101
benrr101 previously approved these changes Jul 25, 2025
Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess since our next scheduled release is 7.0, it's safe to make this change. Otherwise, I'd say we are supposed to cap it at 6.2

apoorvdeshmukh
apoorvdeshmukh previously approved these changes Jul 25, 2025
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.99%. Comparing base (63443f4) to head (2b375f6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3516      +/-   ##
==========================================
+ Coverage   69.90%   69.99%   +0.08%     
==========================================
  Files         276      276              
  Lines       62414    62414              
==========================================
+ Hits        43629    43685      +56     
+ Misses      18785    18729      -56     
Flag Coverage Δ
addons 90.82% <ø> (ø)
netcore 72.93% <ø> (+0.09%) ⬆️
netfx 69.74% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Changed AKV to depend on at least MDS 6.1.0.
@paulmedynski paulmedynski dismissed stale reviews from apoorvdeshmukh and benrr101 via 710c22b July 26, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants