-
Notifications
You must be signed in to change notification settings - Fork 312
Update AKV to depend on any MDS 6.x package #3516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Updated AKV to depend on all MDS 6.x versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider NuGet package specification to expand its dependency version range for Microsoft.Data.SqlClient from [6.0.1,6.1.0)
to [6.0.1,7.0.0)
, making it compatible with all 6.x releases including the latest 6.1.0 version.
- Broadens Microsoft.Data.SqlClient dependency version range to include all 6.x releases
- Maintains backwards compatibility while enabling forward compatibility within the major version
- Applies the change consistently across all target frameworks (net462, net8.0, net9.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess since our next scheduled release is 7.0, it's safe to make this change. Otherwise, I'd say we are supposed to cap it at 6.2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3516 +/- ##
==========================================
- Coverage 69.90% 69.33% -0.58%
==========================================
Files 276 261 -15
Lines 62414 46619 -15795
==========================================
- Hits 43629 32321 -11308
+ Misses 18785 14298 -4487
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Changed AKV to depend on at least MDS 6.1.0.
710c22b
Updated the AKV .nuspec file to declare it depends on any MDS 6.x package. This will make it compatible with the latest MDS 6.1.0 release, and any future MDS 6.x releases.