Skip to content

DEV: unify presence avatar size to make layout shift less likely #33844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

DEV: unify presence avatar size to make layout shift less likely #33844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb91ba3
DEV: unify presence avatar size to make layout shift less likely
awesomerobot Jul 24, 2025
e3b1a72
htmlSafe for CSS
awesomerobot Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ins/discourse-presence/assets/javascripts/discourse/components/topic-presence-display.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export default class TopicPresenceDisplay extends Component {
<div class="presence-avatars">
{{#each this.users as |user|}}
<UserLink @user={{user}}>
{{avatar user imageSize="small"}}
{{avatar user imageSize=@avatarSize}}
</UserLink>
{{/each}}
</div>
Expand Down
30 changes: 24 additions & 6 deletions ...-presence/assets/javascripts/discourse/connectors/topic-above-footer-buttons/presence.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,27 @@
import Component from "@glimmer/component";
import { concat } from "@ember/helper";
import htmlSafe from "discourse/helpers/html-safe";
import { translateSize } from "discourse/lib/avatar-utils";
import TopicPresenceDisplay from "discourse/plugins/discourse-presence/discourse/components/topic-presence-display";

const Presence = <template>
<div class="topic-above-footer-buttons-outlet presence">
<TopicPresenceDisplay @topic={{@outletArgs.model}} />
</div>
</template>;
const AVATAR_SIZE = "small";

export default Presence;
export default class Presence extends Component {
get avatarDimensions() {
return translateSize(AVATAR_SIZE);
}

<template>
<div
style={{htmlSafe
(concat "--avatar-min-height: " this.avatarDimensions "px")
}}
class="topic-above-footer-buttons-outlet presence"
>
<TopicPresenceDisplay
@topic={{@outletArgs.model}}
@avatarSize={{AVATAR_SIZE}}
/>
</div>
</template>
}
8 changes: 5 additions & 3 deletions plugins/discourse-presence/assets/stylesheets/presence.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
.topic-above-footer-buttons-outlet.presence {
min-height: 2.55em; // height of the avatars, prevents layout shift
// slightly larger than avatars to prevent layout shift
min-height: calc(var(--avatar-min-height) + 1px);
padding: var(--space-2) var(--space-2) var(--space-2) 0;
margin: var(--below-topic-margin) 0;
}

.presence-users {
// ideally you don't want to add padding or margin here,
// because you may cause a layout shift on presence appearance
color: var(--primary-medium);
display: flex;
padding: 0.5em;
padding-left: 0;
border-radius: var(--d-border-radius);

span.presence-text {
Expand Down