DEV: unify presence avatar size to make layout shift less likely #33844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerns the presence indicator at the bottom of topics, "replying..." seen here:
Previously we've had cases where the min-height of this element had regressed and ends up causing unwanted layout shift on appearance. (See #33022)
Rather than relying on having the correct magic number here, I've centralized the avatar size in a variable. This then gets translated to a CSS variable and also passed to the component that renders the avatar.
This ensures that
min-height: calc(var(--avatar-min-height) + 1px);will be larger than the avatar and we won't have to worry about our CSS falling out of sync.