🤖 fix: strip trailing slashes from project paths #1065
Merged
+152
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35f251f to
bbf18ca
Compare
Fixes #1063 Project paths with trailing slashes (e.g. '/home/user/project/') caused mangled workspace names because basename('/path/') returns an empty string. Changes: - validateProjectPath() now strips trailing slashes from input paths - loadConfigOrDefault() migrates existing configs by normalizing paths - Added unit tests for both fixes - Added e2e test to verify project names display correctly
bbf18ca to
e79bfa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1063
Project paths with trailing slashes (e.g.
/home/user/project/) caused mangled workspace names becausebasename('/path/')returns an empty string.The fix strips trailing slashes in
validateProjectPath(), which is the central validation point for all project paths.Generated with
mux