Skip to content

Conversation

@geokat
Copy link
Contributor

@geokat geokat commented Dec 8, 2025

Adds --disable-workspace-sharing option.

Workspace sharing is disabled by not including user and group ACLs in the workspace RBAC object, which prevents ACL-based authz.

Closes coder/internal#1072

The commit also adds saving of workspace user/group ACLs in the test DB data generator.

@geokat geokat requested a review from Emyrk as a code owner December 8, 2025 18:45
@geokat geokat requested a review from aslilac December 8, 2025 18:52
@geokat geokat marked this pull request as draft December 8, 2025 19:35
@geokat geokat force-pushed the geokat/feat-deployment-wide-disable-workspace-sharing branch from a55cdb9 to cf147b9 Compare December 8, 2025 20:10
@geokat geokat marked this pull request as ready for review December 8, 2025 20:24
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate, but I understand why it is the way it is

@geokat geokat merged commit 4379230 into main Dec 9, 2025
37 checks passed
@geokat geokat deleted the geokat/feat-deployment-wide-disable-workspace-sharing branch December 9, 2025 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement deployment-wide --disable-workspace-sharing

3 participants