-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add code-review workflow task #21103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
DevelopmentCats
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Code Review
This PR adds a GitHub Actions workflow for AI-powered code reviews using Coder Tasks. The workflow triggers on the "code-review" label and creates a task that analyzes PRs and posts inline suggestions.
Found: 0 issues
✅ Looks good - The workflow follows existing patterns from doc-check.yaml, includes proper error handling with set -euo pipefail, validates inputs appropriately, and uses correct security practices. The implementation is consistent with the codebase standards.
AI review via Coder Tasks
DevelopmentCats
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Code Review
Reviewed GitHub Actions workflow for AI code review.
Found 1 issue (1 portability nitpick) - see inline suggestion for fix.
The workflow follows good patterns from doc-check.yaml with proper error handling, validation, and permissions. The only issue is using GNU-specific grep syntax.
AI review via Coder Tasks
…link for AI-generated summaries
… retrieval and review.json structure
…lines and actionable examples
DevelopmentCats
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Code Review
Reviewed GitHub Actions workflow for code review automation.
✅ Looks good - no production issues found.
This workflow improves upon the existing doc-check.yaml pattern by:
- Including proper URL validation for workflow_dispatch inputs (lines 78-83)
- Using portable
sedinstead of GNU-specificgrep -oPfor URL parsing (line 90) - Including
set -euo pipefailfor proper error handling (line 62)
The workflow correctly handles secrets, validates inputs, and follows GitHub Actions security best practices.
AI review via Coder Tasks
…d focus on actionable feedback
DevelopmentCats
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Code Review
Reviewed AI code review workflow implementation.
Found 3 issues (2 critical, 1 nitpick).
AI review via Coder Tasks
…in code review guidelines
DevelopmentCats
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Code Review
Reviewed AI code review workflow implementation.
✅ Looks good - no production-breaking issues found.
AI review via Coder Tasks
david-fraley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamping approval
This pull request adds a new GitHub Actions workflow,
code-review.yaml, to automate AI-powered code review for pull requests. The workflow creates a Coder Task that uses an AI agent to analyze PR changes, review code quality, identify issues, and post committable suggestions directly on the PR. The workflow can be triggered by adding the "code-review" label or via manual dispatch.Key additions and features:
AI-Powered Code Review Workflow
.github/workflows/code-review.yaml, a comprehensive workflow that triggers on PR labeling or manual dispatch to initiate an AI-driven code review using Coder Tasks.