Skip to content

feat: add code-review workflow task #21103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DevelopmentCats merged 28 commits into from
Dec 12, 2025
+294 −0
Merged

feat: add code-review workflow task #21103

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4001fe5
feat: add code-review task (initial commit)
DevelopmentCats Dec 4, 2025
c6b85ec
temp(workflows): update code-review workflow to use shared secrets fo…
DevelopmentCats Dec 4, 2025
2fea873
refactor: enhance code-review workflow with improved GitHub authentic…
DevelopmentCats Dec 4, 2025
84ccad8
chore: enhance code-review workflow with URL validation and improved …
DevelopmentCats Dec 4, 2025
d94e9df
refactor: update code-review workflow to enhance review phases and su…
DevelopmentCats Dec 4, 2025
724e8b1
fix: security vuln in linting
DevelopmentCats Dec 9, 2025
96e6afd
Merge branch 'main' into cat/code-review-task
DevelopmentCats Dec 9, 2025
647b610
Merge branch 'main' into cat/code-review-task
DevelopmentCats Dec 10, 2025
c7c96e9
Merge branch 'main' into cat/code-review-task
DevelopmentCats Dec 10, 2025
c5fe6c5
chore(workflows): add security instructions for PR content review
DevelopmentCats Dec 10, 2025
96c66d6
Merge branch 'main' into cat/code-review-task
DevelopmentCats Dec 10, 2025
62bf201
chore(workflows): streamline code review process and enhance security…
DevelopmentCats Dec 11, 2025
ca4dd32
Merge branch 'main' into cat/code-review-task
DevelopmentCats Dec 11, 2025
dcaedbd
chore(workflows): update code review prompt for critical suggestion i…
DevelopmentCats Dec 11, 2025
ff8d037
chore(workflows): enhance code review instructions for suggestion for…
DevelopmentCats Dec 11, 2025
a26b00f
chore(workflows): rewrite prompt
DevelopmentCats Dec 11, 2025
595278f
chore(workflows): update code review guidelines to include Coder-spec…
DevelopmentCats Dec 11, 2025
50dc5c0
chore(workflows): refine code review guidelines to emphasize actionab…
DevelopmentCats Dec 11, 2025
8ab152f
chore(workflows): update code review guidelines to address additional…
DevelopmentCats Dec 11, 2025
3d1dd32
chore(workflows): clarify code review guidelines regarding the use of…
DevelopmentCats Dec 11, 2025
5d9492b
chore: apply code-review suggestion for gnu specific syntax
DevelopmentCats Dec 11, 2025
32e54e8
chore(workflows): update code review comments to include Coder Tasks …
DevelopmentCats Dec 11, 2025
7ba4bdf
chore(workflows): simplify code review process by updating commit SHA…
DevelopmentCats Dec 11, 2025
f0eaa46
chore(workflows): improve portability of PR number extraction by repl…
DevelopmentCats Dec 11, 2025
d6cdd8f
Merge branch 'main' into cat/code-review-task
DevelopmentCats Dec 12, 2025
50281ce
chore(workflows): enhance code review instructions with clearer guide…
DevelopmentCats Dec 12, 2025
fb144d5
chore(workflows): update code review guidelines to enhance clarity an…
DevelopmentCats Dec 12, 2025
9a5f70f
chore(workflows): improve error handling and clarify set -u behavior …
DevelopmentCats Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: security vuln in linting
  • Loading branch information
@DevelopmentCats
DevelopmentCats committed Dec 9, 2025
commit 724e8b151124db6bec048c9e0e2118b38e36ee11
7 changes: 5 additions & 2 deletions .github/workflows/code-review.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,12 @@ jobs:

- name: Extract repository info
id: repo-info
env:
REPO_OWNER: ${{ github.repository_owner }}
REPO_NAME: ${{ github.event.repository.name }}
run: |
Copy link
Contributor Author

@DevelopmentCats DevelopmentCats Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Missing error handling directives for this shell script block.

Suggested change
run: |
run: |
set -euo pipefail
echo "owner=${{ github.repository_owner }}" >> "${GITHUB_OUTPUT}"

Copy link
Contributor Author

@DevelopmentCats DevelopmentCats Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important: Missing set -euo pipefail for consistency with other shell script blocks.

Suggested change
run: |
run: |
set -euo pipefail
echo "owner=${{ github.repository_owner }}" >> "${GITHUB_OUTPUT}"

echo "owner=${{ github.repository_owner }}" >> "${GITHUB_OUTPUT}"
echo "repo=${{ github.event.repository.name }}" >> "${GITHUB_OUTPUT}"
echo "owner=${REPO_OWNER}" >> "${GITHUB_OUTPUT}"
Copy link
Contributor Author

@DevelopmentCats DevelopmentCats Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Missing set -euo pipefail at the start of the script block.

Impact: Without these flags, undefined variables or command failures won't cause the step to fail. This could lead to silent failures where empty values are written to GITHUB_OUTPUT.

Suggested change
echo "owner=${REPO_OWNER}" >> "${GITHUB_OUTPUT}"
run: |
set -euo pipefail

echo "repo=${REPO_NAME}" >> "${GITHUB_OUTPUT}"

- name: Build code review prompt
id: build-prompt
Expand Down