-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor: replace MUI Tooltip component with Tooltip (simple usage) #20849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I originally felt it was necessary to create a new component,
|
aslilac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked a few of the tooltips, and the code looks good!
for #19974
Redo of #20027, this time splitting it into multiple PRs + using our existing
Tooltipcomponent instead of creating a new component (see below). This PR covers the most basic usage of the MUI Tooltip, i.e., the tooltip content is a string literal.Adds a global<- this was done by #20869TooltipProvidertoAppProvidersand our Storybook decorators, so that we don't have to render aTooltipProviderfor every tooltip instance. Removing redundantTooltipProviders will be another separate PR