Skip to content

fix: wait for build in task status load generator #20800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spikecurtis merged 1 commit into from
Nov 19, 2025
Merged

fix: wait for build in task status load generator #20800

spikecurtis merged 1 commit into from
Nov 19, 2025

Conversation

@spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Nov 17, 2025 •
edited
Loading

Wait for the External workspace build job to complete before attempting to pull its credentials from Coder. This resolves a race in the load generator.

This was referenced Nov 17, 2025
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Nov 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis mentioned this pull request Nov 17, 2025
Merged
@spikecurtis spikecurtis force-pushed the spike/internal-913-wait-for-build branch from d1d73cd to 436e32a Compare November 17, 2025 12:25
@spikecurtis spikecurtis force-pushed the spike/internal-913-runner-cleanup branch from 279e6cf to 0035049 Compare November 17, 2025 12:25
@spikecurtis spikecurtis marked this pull request as ready for review November 17, 2025 12:36
@spikecurtis spikecurtis force-pushed the spike/internal-913-wait-for-build branch from 436e32a to 9a3660d Compare November 17, 2025 12:50
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Nov 19, 2025 •
edited
Loading

Merge activity

  • Nov 19, 6:13 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 19, 6:26 AM UTC: Graphite rebased this pull request as part of a merge.
  • Nov 19, 6:35 AM UTC: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis changed the base branch from spike/internal-913-runner-cleanup to graphite-base/20800 November 19, 2025 06:14
@spikecurtis spikecurtis changed the base branch from graphite-base/20800 to main November 19, 2025 06:24
@spikecurtis spikecurtis force-pushed the spike/internal-913-wait-for-build branch from 9a3660d to da5eec8 Compare November 19, 2025 06:25
@spikecurtis spikecurtis merged commit 8ee6e94 into main Nov 19, 2025
30 of 31 checks passed
@spikecurtis spikecurtis deleted the spike/internal-913-wait-for-build branch November 19, 2025 06:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees

@spikecurtis spikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spikecurtis @ethanndickson