Skip to content

feat: add task status reporting load generator runner #20538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spikecurtis merged 1 commit into from
Nov 13, 2025
Merged

feat: add task status reporting load generator runner #20538

spikecurtis merged 1 commit into from
Nov 13, 2025

Conversation

@spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Oct 29, 2025 •
edited
Loading

Adds the Runner, Config, and Metrics for the scaletest load generator for task status.

Part of coder/internal#913

@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Oct 29, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis mentioned this pull request Oct 29, 2025
Merged
@spikecurtis spikecurtis marked this pull request as ready for review October 29, 2025 12:06
@spikecurtis spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from 6301335 to 6d573a2 Compare October 29, 2025 12:19
ethanndickson
ethanndickson approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nitpicks from me

scaletest/taskstatus/config.go
MetricLabelValues []string `json:"metric_label_values"`
}

func (c *Config) Validate() error {
Copy link
Member

@ethanndickson ethanndickson Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks unused

@spikecurtis spikecurtis changed the base branch from spike/scaletest-refactor-workspace-target-flags to graphite-base/20538 October 30, 2025 07:10
@spikecurtis spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from 6d573a2 to 8bafc4f Compare October 30, 2025 07:10
@graphite-app graphite-app bot changed the base branch from graphite-base/20538 to main October 30, 2025 07:11
@spikecurtis spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from 8bafc4f to bd4b0c6 Compare October 30, 2025 07:11
@github-actions github-actions bot added stale This issue is like stale bread. and removed stale This issue is like stale bread. labels Nov 7, 2025
@spikecurtis spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from bd4b0c6 to a606f12 Compare November 13, 2025 10:25
@spikecurtis spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from a606f12 to 1a891c3 Compare November 13, 2025 12:12
@spikecurtis spikecurtis mentioned this pull request Nov 13, 2025
Merged
@spikecurtis spikecurtis merged commit a3c851c into main Nov 13, 2025
31 checks passed
@spikecurtis spikecurtis deleted the spike/internal-913-taskstatus-runner branch November 13, 2025 12:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees

@spikecurtis spikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spikecurtis @ethanndickson