Skip to content

feat: implement agent socket api, client and cli #20758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SasSwart merged 11 commits into from
Nov 28, 2025
Merged

feat: implement agent socket api, client and cli #20758

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
071fb1f
feat(agent): integrate socket server into agent lifecycle
SasSwart Nov 11, 2025
cadccf6
appease the linter
SasSwart Nov 11, 2025
c8e8c20
fix agent build post rebase
SasSwart Nov 21, 2025
01d830e
Add yamux to the agentsocket client and add an error stub for it in w…
SasSwart Nov 21, 2025
be91743
remove yamux from the agentsocket api
SasSwart Nov 24, 2025
19f6094
make comment more specific
SasSwart Nov 24, 2025
4b245ab
further simplify agentsocket server initialization
SasSwart Nov 24, 2025
dfee909
fix agent socket build on windows
SasSwart Nov 24, 2025
a9362a2
remove a redundant line
SasSwart Nov 24, 2025
75771dc
chore: add agentsocket api client (#20718)
SasSwart Nov 27, 2025
55be91a
Merge branch 'main' into jjs/internal-1095-branch3-agent-integration
SasSwart Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add yamux to the agentsocket client and add an error stub for it in w… 
…indows
  • Loading branch information
@SasSwart
SasSwart committed Nov 21, 2025
commit 01d830e49024bf9bf7b36a325454d89a089bbff8
4 changes: 2 additions & 2 deletions agent/agentsocket/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import (
"github.com/coder/coder/v2/agent/agentsocket"
"github.com/coder/coder/v2/agent/agentsocket/proto"
"github.com/coder/coder/v2/agent/unit"
"github.com/coder/coder/v2/codersdk/drpcsdk"
)

// tempDirUnixSocket returns a temporary directory that can safely hold unix
Expand Down Expand Up @@ -58,7 +57,8 @@ func newSocketClient(t *testing.T, socketPath string) proto.DRPCAgentSocketClien
session, err := yamux.Client(conn, config)
require.NoError(t, err)

client := proto.NewDRPCAgentSocketClient(drpcsdk.MultiplexedConn(session))
client, err := agentsocket.NewClient(socketPath, slog.Make().Leveled(slog.LevelDebug))
require.NoError(t, err)

t.Cleanup(func() {
_ = session.Close()
Expand Down
6 changes: 6 additions & 0 deletions agent/agentsocket/socket_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package agentsocket
import (
"net"

"cdr.dev/slog"
"golang.org/x/xerrors"
)

Expand All @@ -25,3 +26,8 @@ func cleanupSocket(_ string) error {
// No-op since agentsocket is not supported on Windows
return nil
}

// NewClient creates a DRPC client for the agent socket at the given path.
func NewClient(path string, logger slog.Logger) (*Client, error) {
return nil, xerrors.New("agentsocket is not supported on Windows")
}
Loading