feat(coderd): add lookup task by name in httpmw.TaskParam #20647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
reviewed
Nov 3, 2025
Member
mafredri
left a comment
There was a problem hiding this comment.
With this change we can remove the custom code in codersdk (used by CLI/toolsdk).
mafredri
reviewed
Nov 3, 2025
Member
mafredri
left a comment
There was a problem hiding this comment.
Minor nits/suggestions but otherwise looks pretty good. I see one of the previous comments are not addressed yet but once fixed I think this is good to go 👍🏻
mafredri
approved these changes
Nov 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetTaskByOwnerIDAndNamequeryhttpmw.TaskParamto fall back to task name if no task by UUID found.Note: I originally added a tertiary fallback to lookup by workspace name but elected to remove it for simplicity.
Mostly generated by Claude with manual refactoring.