Cherry-pick for release 2.25 #19169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

stirby merged 7 commits into release/2.25 from cherries/2.25

Aug 5, 2025

Collaborator

stirby commented Aug 4, 2025

Presets Validation
f256a23a773e235213f6fc53cf5dcf527c0601d8

Devcontainers: disable project autostart by default
b8e2344ef54b1f88af33935f1afb588f566f42a6

Set valid xcode version in release script
b95cf47f9998e21f8d97c913424f5ec052c4ab19

Remote Coder MCP server documentation
a02d1c1e59e2c4c8efa8a802eba04a84bc4af22b

Add Coder OAuth2 provider experimental documentation
247efc0dcc7da73cd2ae80ad08d1491c8825c163

SasSwart and others added 5 commits

August 4, 2025 17:53


          feat: validate presets on template import (#18844)

74bdb7a

Typos and other errors often result in invalid presets in a template.
Coder would import these broken templates and present them to users when
they create workspaces. An unsuspecting user who chooses a broken preset
would then experience a failed workspace build with no obvious error
message.

This PR adds additional validation beyond what is possible in the
Terraform provider schema. Coder will now present a more helpful error
message to template authors when they upload a new template version:

<img width="1316" height="286" alt="Screenshot 2025-07-14 at 12 22 49"
src="/api/flow.js?q=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F%253Ca%2520href%3D"https://github.com/user-attachments/assets/7f5f778f-d9ae-487a-95e2-f6f1ca604a9c">https://github.com/user-attachments/assets/7f5f778f-d9ae-487a-95e2-f6f1ca604a9c"
/>

The frontend warning is less helpful right now, but I'd like to address
that in a follow-up since I need frontend help:

<img width="1102" height="616" alt="image"
src="/api/flow.js?q=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F%253Ca%2520href%3D"https://github.com/user-attachments/assets/e838ffc8-ef4f-428d-9280-74fa0c491666">https://github.com/user-attachments/assets/e838ffc8-ef4f-428d-9280-74fa0c491666"
/>

closes #17333

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Improved validation and error reporting for template presets,
providing clearer feedback when presets cannot be parsed or reference
undefined parameters.

* **Bug Fixes**
* Enhanced error handling during template version creation to better
detect and report issues with presets.

* **Tests**
* Added new tests to verify validation of both valid and invalid
Terraform presets during template version creation.
* Improved test reliability by enabling dynamic control over error
injection in database-related tests.

* **Chores**
* Updated a dependency to the latest version for improved stability and
features.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit f256a23)


          chore(agent/agentcontainers): disable project autostart by default (#…

4b227f5

…19114)

We disable the logic that allows autostarting discovered devcontainers
by default. We want this behavior to be opt-in rather than opt-out.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
(cherry picked from commit b8e2344)


          ci: set valid xcode version in release script (#19143)

267d9be

16.0.0 was yanked from the macOS runners, so this will likely need cherry picking into the upcoming release branch.

We've already checked everything builds fine on #19125.

In a few releases we'll stop building the dylib and also therefore remove xcode as a dependency on coder/coder altogether.

(cherry picked from commit b95cf47)


          docs: document how to start a remote MCP Coder server (#19150)

37d0386

Document how to start a remote MCP Coder server. Addresses
coder/internal#823.

(cherry picked from commit a02d1c1)


          docs: add OAuth2 provider experimental feature documentation (#19165)

2f9e272

# Add OAuth2 Provider Documentation

This PR adds comprehensive documentation for the experimental OAuth2
Provider feature, which allows Coder to function as an OAuth2
authorization server. The documentation covers:

- Feature overview and experimental status warning
- Setup requirements and enabling the feature
- Methods for creating OAuth2 applications (UI and API)
- Integration patterns including standard OAuth2 and PKCE flows
- Discovery endpoints and token management
- Testing and development guidance
- Troubleshooting common issues
- Security considerations and current limitations

The documentation is marked as experimental and includes appropriate
warnings about production usage.

Signed-off-by: Thomas Kosiewski <tk@coder.com>
(cherry picked from commit 247efc0)

stirby requested a review from Emyrk as a code owner

August 4, 2025 19:08

github-actions bot assigned stirby

hugodutka and others added 2 commits

August 4, 2025 19:22


          docs: oauth2-provider fixes (#19170)

b8be8cd

Adds the oauth2-provider doc page to the manifest so it's rendered in
the docs, fixes formatting in the oauth2-provider doc, and links to it
from the MCP doc.

To see the formatting issues, visit
https://coder.com/docs/@4bcf44a/admin/integrations/oauth2-provider. To
see the doc after the fixes, visit
https://coder.com/docs/@f05969a/admin/integrations/oauth2-provider.

(cherry picked from commit c94333d)


          ci: conditionally disable spotlight indexing (#19124)

f54c8fe

Work around for following issue:
```
Run sudo mdutil -a -i off
  sudo mdutil -a -i off
  sudo mdutil -X /
  sudo launchctl bootout system /System/Library/LaunchDaemons/com.apple.metadata.mds.plist
  shell: /bin/bash -e {0}
4 files/directories removed
Boot-out failed: 5: Input/output error
```

This can happen if spotlight has already been disabled.

(cherry picked from commit 6a35400)

stirby requested a review from sreya

August 4, 2025 20:59

sreya approved these changes

View reviewed changes

stirby merged commit e6ec957 into release/2.25

31 of 34 checks passed

stirby deleted the cherries/2.25 branch

August 5, 2025 16:50

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet