chore(agent/agentcontainers): disable project autostart by default #19114
+119
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We disable the logic that allows autostarting discovered devcontainers by default. We want this behavior to be opt-in rather than opt-out.
There was a problem hiding this comment.
Pull Request Overview
This PR disables autostarting of discovered devcontainer projects by default, making this behavior opt-in rather than opt-out for better control over automatic project initialization.
- Adds a new CLI flag
--devcontainers-discovery-autostart-enable(defaults to false) - Wraps autostart logic with a conditional check based on the new setting
- Updates tests to verify the new disabled-by-default behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/testdata/coder_agent_--help.golden | Updates help text to include the new autostart flag documentation |
| cli/agent.go | Adds CLI flag and option configuration for discovery autostart control |
| agent/agentcontainers/api_test.go | Adds test case to verify autostart is disabled by default |
| agent/agentcontainers/api.go | Implements the autostart conditional logic and option setter |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disable the logic that allows autostarting discovered devcontainers by default. We want this behavior to be opt-in rather than opt-out.