Skip to content

fix: handle potential DB conflict due to concurrent upload requests in postFile #19005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
+42 −5
Merged

fix: handle potential DB conflict due to concurrent upload requests in postFile #19005

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a009ba7
handle conflict in postFile
cstyan Jul 22, 2025
df947ef
add test to ensure that concurrent file uploads don't result in an error
cstyan Jul 22, 2025
f6ae297
fix linting
cstyan Jul 22, 2025
b71c58a
add log line if we hit the unique violation error case
cstyan Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix linting 
Signed-off-by: Callum Styan <callumstyan@gmail.com>
  • Loading branch information
@cstyan
cstyan committed Jul 22, 2025
commit f6ae297c1f4f7303d24693c969dc4ab97dbf0b09
4 changes: 0 additions & 4 deletions coderd/files_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,9 @@ func TestPostFiles(t *testing.T) {
end.Done()
require.NoError(t, err)
}()

}
wg.Done()
end.Wait()

// _, err = client.Upload(ctx, codersdk.ContentTypeTar, bytes.NewReader(data))
// require.NoError(t, err)
})
}

Expand Down
Loading