Skip to content

feat: allow iframing urls on the same domain as the deployment #18102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2025
Merged

feat: allow iframing urls on the same domain as the deployment #18102

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
edb2314
feat: allow iframing urls on the same domain as the deployment
Emyrk May 29, 2025
648c707
chore: toggle with experiment
Emyrk May 29, 2025
b3ac3ee
fixup test
Emyrk May 29, 2025
95f3b61
also add frame-src
Emyrk May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coderd/httpmw/csp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func CSPHeaders(telemetry bool, websocketHosts func() []string, staticAdditions
CSPDirectiveMediaSrc: {"'self'"},
// Report all violations back to the server to log
CSPDirectiveReportURI: {"/api/v2/csp/reports"},
CSPFrameAncestors: {"'none'"},
CSPFrameAncestors: {"'self'"},

// Only scripts can manipulate the dom. This prevents someone from
// naming themselves something like '<svg onload="alert(/cross-site-scripting/)" />'.
Expand Down
Loading