fix: close popover when notification settings are clicked #17001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 2 commits into main from bq/close-popover-when-click-settings

Mar 19, 2025

Collaborator

BrunoQuaresma commented Mar 19, 2025

When a user clicks in the notification settings does not make sense to keep the popover open, instead, we want to close it.


          fix: close popover when notification settings are clicked

b805a12

BrunoQuaresma added the hotfix label

BrunoQuaresma requested a review from mtojek

March 19, 2025 13:32

BrunoQuaresma self-assigned this

cdr-bot bot approved these changes

View reviewed changes

cdr-bot bot left a comment

This PR is a hotfix and has been automatically approved.

✅ Base is main or release branch
✅ Has hotfix label
✅ Head is from coder/coder
✅ Less than 100 lines

FMT

209a77e

mtojek approved these changes

View reviewed changes

Member

mtojek left a comment

👍

BrunoQuaresma merged commit 4a54802 into main

30 checks passed

BrunoQuaresma deleted the bq/close-popover-when-click-settings branch

March 19, 2025 13:52

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet