Move `common` -> `crates/common` #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

youknowone merged 1 commit into RustPython:main from ShaharNaveh:move-common

Nov 14, 2025

Collaborator

ShaharNaveh commented Nov 14, 2025 •

edited

Loading

ref: #6214

Summary by CodeRabbit

Chores
- Reorganized project structure and workspace dependencies configuration.


          Move common -> crates/common

090a777

Contributor

coderabbitai bot commented Nov 14, 2025 •

edited

Loading

Walkthrough

The workspace structure is being reorganized by relocating the "common" crate from the root directory into a crates/ subdirectory. The Cargo.toml workspace members list is updated to remove the direct reference, and the dependency path is adjusted to point to the new location.

Changes

Cohort / File(s)	Summary
Workspace restructuring `Cargo.toml`	Removed "common" from workspace members list; updated rustpython-common dependency path from `"common"` to `"crates/common"`

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Single configuration file with straightforward path updates
No logic changes or functional implications
Verify that the new path crates/common correctly points to the relocated crate structure

Possibly related PRs

Dependencies cleanup #6151: Related workspace restructuring—modifies Cargo.toml entries for the common crate, likely part of the same directory reorganization effort.

Poem

🐰 Hop hop, reorganize!
Common moves to crates with pride,
Workspace paths all realigned,
Structure grows, no logic harmed,
Fresh new home, workspace charmed! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main change: moving the 'common' directory to 'crates/common', which matches the file-level changes in Cargo.toml.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 609d99f and 090a777.

📒 Files selected for processing (1)

Cargo.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Check the WASM package and demo
GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Run tests under miri
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Check Rust code with clippy
GitHub Check: Run rust tests (windows-latest)
GitHub Check: Ensure compilation on various targets
GitHub Check: Run rust tests (macos-latest)
GitHub Check: auto_format

🔇 Additional comments (1)

Cargo.toml (1)

153-153: Cargo.toml path update is correct and complete; the common crate migration to crates/common is properly configured.

The verification confirms:

crates/common directory exists

The path update in line 153 from "common" to "crates/common" correctly reflects the new location

Workspace members includes the "crates/*" wildcard pattern, which captures the relocated crate

No stale references to the old path remain

The workspace structure is intentionally reorganized to place certain crates (common, doc) under crates/ while keeping others at the root level

The change is complete, consistent, and ready to build.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ShaharNaveh mentioned this pull request

Organize our rust code into crates/ directory #6214

Open

16 tasks

youknowone merged commit 4b7e49a into RustPython:main

13 checks passed

This was referenced Nov 14, 2025

Move compiler/codegen -> crates/codegen #6260

Merged

Move derive -> crates/derive #6264

Merged

Move stdlib -> crates/stdlib #6268

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet