-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Dependencies cleanup #6151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies cleanup #6151
Conversation
WalkthroughWorkspace-wide dependency version bumps and additions, several crate Cargo.toml dependency removals/relocations, and benchmark updates replacing Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Bench as Benchmark
participant PyO3 as pyo3
participant GIL as GIL
participant VM as Python_VM
Note over Bench,PyO3: New flow uses Python::attach for GIL scope
Bench->>PyO3: Python::attach(|py| { ... })
activate PyO3
PyO3->>GIL: attach current thread (GIL acquired)
activate GIL
GIL->>VM: compile & execute Python code
VM-->>GIL: result / error
deactivate GIL
PyO3-->>Bench: closure returns with result
deactivate PyO3
Note over Bench: Measurements use std::hint::black_box for isolation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Cargo.toml
Outdated
| bstr = "1" | ||
| cfg-if = "1.0" | ||
| chrono = "0.4.39" | ||
| chrono = "0.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using chrono features of later versions. e.g. 0.4.10 is not compatible. This will cause dependency resolver success but build fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about other libraries? To remove patch version, we have to ensure it is buildable with x.y.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, I'll revert. And will open a PR for base dependentabot config. this should ease the upgrade process
Summary by CodeRabbit
Chores
Tests
Refactor