fix(parser): Disallow CR in frontmatter #149823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

epage wants to merge 5 commits into rust-lang:main from epage:f

+42 −8

Contributor

epage commented Dec 9, 2025 •

edited by rustbot

Loading

T-lang came back on the stabilization PR (#148051) asking for CR to be disallowed
with the intention of preventing confusing situations where a stray CR
looks like a line break.

If need arises for it, this could always be turned into a lint at a
later point.

Part of #136889

epage added 5 commits

December 9, 2025 14:56


          test(frontmatter): Show behavior for straw cr

b9a1601


          refactor(parse): Be consistent in naming

6838b54


          refactor(parse): Consistently use real_s

63b09bf


          refactor(parse): Use a common frame of reference

d08b23b


          fix(parser): Disallow CR in frontmatter

79212ba

T-lang came back on the stabilization PR asking for CR to be disallowed
with the intention of preventing confusing situations where a stray CR
looks like a line break.

If need arises for it, this could always be turned into a lint at a
later point.

epage added the F-frontmatter label

rustbot assigned lcnr

rustbot added S-waiting-on-review T-compiler labels

Collaborator

rustbot commented Dec 9, 2025

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

epage mentioned this pull request

Stabilize Frontmatter #148051

Open

10 tasks

traviscross added the I-lang-radar label

Member

joshtriplett commented Dec 10, 2025 •

edited

Loading

Given that text-direction-codepoint-in-literal and text-direction-codepoint-in-comment are lints, I do think it makes sense for this and the similar error in raw strings to be a lint as well. I doubt that anyone is going to allow it, but I still think it makes sense to not be a hard error.

That said, I don't think switching this from a hard error to a lint should be a blocker. Let's go ahead with the simple version of this change to unblock stabilization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-frontmatter I-lang-radar S-waiting-on-review T-compiler