yf.download has unintuitive performance with range of arguments #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

cole-st-john wants to merge 2 commits into ranaroussi:main from cole-st-john:price-history

Contributor

cole-st-john commented May 7, 2025

Problem:

This PR is around two issues:

Issues with use of period="max" - described here: #2451
Some issues or unintuitive results with other sets of time constraints:
- Use of Start, End and Period doesnt error out (overconstraint)
- Use of Start and Period is not supported (it first assigns arbitrary end despite the other args)

The initial purpose of this pull request to provide a TDD style set of tests that should be met with code changes. But first I wanted to query for feedback about this initial information.

cole-st-john added 2 commits

May 7, 2025 18:35


          Added basic range of interval tests for period="max" in yf.download

360635b


          Added TDD-style tests yf.download for range of time-constraint args

2e45d1b

cole-st-john marked this pull request as draft

May 7, 2025 16:50

ValueRaider force-pushed the main branch from 73dabcd to 0eb11c5 Compare

June 11, 2025 20:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet