Experiment with the CGAL Epeck kernel #6322
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use the
CGAL::Cartesian<Gmpq>kernel. The main challenge with this kernel is that it has severe performance challenges. Discussing with some CGAL folks revealed that theEpeck"filtered" kernel should give the same guarantees as this kernel, but will only useGmpqnumbers when necessary, yielding a significant performance boost compared to the kernel we use today.Before making the switch, we need to run a significant amount of corner-case tests + performance tests to both validate the performance impact and make sure we don't introduce any stability issues.