Add inputs_to_logits_ratio to LasrCTCConfig #42720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kho wants to merge 3 commits into huggingface:main from kho:inputs_to_logits_ratio

+20 −3

Contributor

kho commented Dec 8, 2025

What does this PR do?

This PR adds inputs_to_logits_ratio to LasrCTCConfig so that LasrForCTC can be used in an ASR pipeline with chunked decoding.

Before submitting

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline,
Pull Request section?
Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?


          Add inputs_to_logits_ratio to LasrCTCConfig

a7162c9

Contributor Author

kho commented Dec 8, 2025

@eustlb make fixup is not yet passing due to hop_length not being used in modelling code.

pcuenca requested a review from eustlb

December 10, 2025 09:11


          changes

6d5ab9e

Contributor

github-actions bot commented Dec 10, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: lasr

nit

eustlb reviewed

View reviewed changes

Contributor

eustlb left a comment

hop_length should be accessed directly from the feature extractor. @kho do you confirm this suits your needs?

Contributor Author

kho commented Dec 10, 2025

Unfortunately this will break decoding with LM. Perhaps we should just hardcode hop_length to a fixed value for now in LasrFeatureExtractor?

Contributor Author

kho commented Dec 10, 2025

@eustlb I created #42782 as a Plan B. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet