chore: simplify implicit echo provision responses #21225
+38
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
b574e56 to
d8eebf8
Compare
d8eebf8 to
3c0e165
Compare
3c0e165 to
b035eac
Compare
spikecurtis
approved these changes
Dec 12, 2025
fbe25b0 to
eb2d7a5
Compare
6025829 to
91f2191
Compare
91f2191 to
e3c3ffe
Compare
eb2d7a5 to
b95b7f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spikecurtis this simplifies that "magic" logic in the responses, but it still implicitly adds
<Step>Completewhen things are nil. To prevent a massive diff.We have >100 tests that would require adding the
Init/Plan/ApplyComplete. I think this diff is a good middle ground.