Skip to content

feat: add workspace sharing indicator #21222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jaaydenh wants to merge 2 commits into
base: geokat/internal-858-sharing-info-in-workspaces-response
Choose a base branch
from
Open

feat: add workspace sharing indicator #21222

jaaydenh wants to merge 2 commits into from
+237 −2

Conversation

@jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Dec 11, 2025 •
edited
Loading

Screenshot 2025-12-11 at 13 10 01

@jaaydenh jaaydenh self-assigned this Dec 11, 2025
@jaaydenh jaaydenh requested a review from aslilac December 11, 2025 13:34
aslilac
aslilac approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but design wise...

  • in the original design, the settings link was a button
  • I feel like things look a little vertically cramped. could we add just a bit more gap/padding in between?
Image

@geokat geokat force-pushed the geokat/internal-858-sharing-info-in-workspaces-response branch from 629e5b4 to 73a619c Compare December 12, 2025 15:16
@jaaydenh
Copy link
Contributor Author

jaaydenh commented Dec 12, 2025

@aslilac I was referencing the new designs created by christin, https://www.figma.com/design/CNr6qGcPhbq3Qut6rENz6i/Shared-Workspaces?node-id=168-3958&t=Ga6q3znU5CzyVLZO-1

Good catch on the settings button, I changed this because of the designs but I actually think the button is the correct UI here.

Screenshot 2025-12-12 at 15 10 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@jaaydenh jaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaaydenh @aslilac