feat(cli): display template version name in push output #21192
+85
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when running `coder templates push` without specifying a `--name` flag, the backend would autogenerate a version name (e.g., "kind_nightingale"), but the CLI never displayed this name to the user. This made it difficult to reference the version later. This change updates the success message to include the version name, whether it was autogenerated or user-specified. Output changes from: "Updated version at Jan 2 15:04:05!" to: "Updated version kind_nightingale at Jan 2 15:04:05!" Closes #21111 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The test was expecting the old output format "Updated version at" but
the new format is "Updated version {name} at". Updated the test to
match the beginning of the output string.
The pty.Output() call was causing an error after the command completed. The test already verifies the output format with ExpectMatchContext, so we only need to verify the version was created in the database.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the coder templates push CLI command to display the template version name (whether autogenerated or user-specified) in the success message, making it easier for users to reference the version later.
Key Changes:
- Updated the success message format from "Updated version at {time}" to "Updated version {name} at {time}"
- Added version name styling with the Keyword style for visual consistency
- Added comprehensive test coverage for both autogenerated and user-specified version names
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/templatepush.go | Modified success message to include version name with proper styling |
| cli/templatepush_test.go | Updated existing test assertion and added two new tests to verify version name display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
phorcys420
reviewed
Dec 10, 2025
Member
phorcys420
left a comment
There was a problem hiding this comment.
Looks good, and tests look fine, but i will let someone else cross check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Display the template version name in
coder templates pushCLI output.Problem
When running
coder templates pushwithout the--nameflag, the backend autogenerates a version name (e.g., "kind_nightingale") using Docker-style random names. However, the CLI never displayed this autogenerated name to the user, making it difficult to reference the version later.Fix
Updated the success message at
cli/templatepush.go:207to include the version name in the output. The version name is styled with theKeywordstyle for consistency with other CLI output (like template names).Before:
After:
This works for both autogenerated names and user-specified names (via
--nameflag).Test Plan
Added two new test cases in
cli/templatepush_test.go:TestTemplatePush/DisplayAutogeneratedVersionName- Verifies autogenerated names are displayedTestTemplatePush/DisplayUserSpecifiedVersionName- Verifies user-specified names are displayedBoth tests verify that:
Tests will run in CI (cannot run locally due to Docker requirements).
Closes #21111
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com