feat(scripts): create both docker and tasks-docker templates by default for develop.sh #21184
+48
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I have confirmed this works! |
geokat
reviewed
Dec 9, 2025
a82d8b2 to
34d30a5
Compare
Add a --with-tasks flag to develop.sh that automatically sets up a tasks-compatible development environment. When enabled, it creates the tasks-docker template and pulls the required container image in the background to speed up workspace creation. The flag also sets a blank access URL to enable tunnel mode, which provides automatic subdomain support for workspace apps without requiring wildcard-access-url configuration. Updated the dogfood template to use this flag by default, making it easier to develop Coder Tasks features using Tasks itself. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The DOCKER_HOST variable was being set but not passed to the template. This commit: - Creates params.yaml with docker_socket parameter - Passes params.yaml via --variables-file flag to both template pushes - Adds docker_socket variable to tasks-docker template matching docker template pattern This ensures the template can connect to non-default Docker sockets when needed.
Per Dean's feedback, remove the --with-tasks flag and always create both the docker and tasks-docker templates in develop.sh. This provides a better developer experience by making the tasks-docker template available without requiring a flag. Changes: - Remove --with-tasks flag and associated argument parsing - Always create both docker and tasks-docker templates when docker is available - Pull container image in background for tasks-docker to speed up workspace creation - Update dogfood template to remove --with-tasks usage (no longer needed)
The main.tf changes were unrelated to this PR. Reverting to match main branch exactly.
4e115ea to
f98cf44
Compare
Addresses Dean's code review feedback: - Remove redundant first_org_name variable in tasks-docker section (already defined in docker section above) - Extract template pushing logic into a shared push_template() function to reduce code duplication between docker and tasks-docker template creation
…late The tasks-docker example template doesn't need custom docker socket configuration - it works fine with the default docker provider configuration. Removed the docker_socket variable addition and updated push_template() function to optionally use params.yaml only when it exists.
|
|
||
| DOCKER_HOST="$(docker context inspect --format '{{ .Endpoints.docker.Host }}')" | ||
| printf 'docker_arch: "%s"\ndocker_host: "%s"\n' "${GOARCH}" "${DOCKER_HOST}" >"${temp_template_dir}/params.yaml" | ||
| ( |
Member
There was a problem hiding this comment.
Not a big deal but the parenthesis are not required anymore.
Comment on lines
+277
to
+300
| if docker info >/dev/null 2>&1 && ! "${CODER_DEV_SHIM}" templates versions list "${template_name}" >/dev/null 2>&1; then | ||
| # sometimes terraform isn't installed yet when we go to create the | ||
| # template | ||
| echo "Waiting for terraform to be installed..." | ||
| sleep 5 | ||
|
|
||
| echo "Initializing tasks-docker template..." | ||
|
|
||
| # Pull the container image in the background to speed up workspace creation | ||
| container_image="codercom/example-universal:ubuntu" | ||
| echo "Pulling container image ${container_image} in background..." | ||
| docker pull "${container_image}" >/dev/null 2>&1 & | ||
|
|
||
| # Create template from the examples directory | ||
| temp_template_dir="$(mktemp -d)" | ||
| cp -r "${PROJECT_ROOT}/examples/templates/tasks-docker/"* "${temp_template_dir}/" | ||
|
|
||
| # Run terraform init so we get a terraform.lock.hcl | ||
| pushd "${temp_template_dir}" && terraform init && popd | ||
|
|
||
| ( | ||
| push_template "${template_name}" "${temp_template_dir}" "${first_org_name}" "${another_org}" | ||
| ) || echo "Failed to create tasks-docker template. The template files are in ${temp_template_dir}" | ||
| fi |
Member
There was a problem hiding this comment.
Can we not make the regular docker template the same as this? It's missing the terraform check, the background pulling, the terraform init. It'd be nice if these could just be identical and just be ~two lines
| # sometimes terraform isn't installed yet when we go to create the | ||
| # template | ||
| echo "Waiting for terraform to be installed..." | ||
| sleep 5 |
Member
There was a problem hiding this comment.
This needs to be a (bounded) loop with command -v terraform or something to test for it being installed rather than a sleep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
--with-tasksflag and always create both docker and tasks-docker templates in develop.sh. This provides a better developer experience by making the tasks-docker template available automatically without requiring a flag.When docker is available, the script now:
examples/templates/tasks-dockercodercom/example-universal:ubuntu) in the background to speed up workspace creation🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com